is_strict and is_fallible docs improvement - #9122
Conversation
| /// A strict function returns null for a row when any argument is null for that row. This | ||
| /// matches PostgreSQL's `STRICT` convention for null propagation. |
There was a problem hiding this comment.
best I can find is https://www.postgresql.org/docs/current/sql-createfunction.html and that description is honestly not great.
f7ddb2a to
5806a43
Compare
| /// Returning `false` permits speculative evaluation. Dictionary push-down evaluates every | ||
| /// dictionary value, including values that no input row references. A fallible function could | ||
| /// therefore error on a value that normal evaluation (without pushdown) would never reach. |
There was a problem hiding this comment.
Isn't this kind of how speculative execution works? We can apply the operation beforehand without knowing if it is used or not
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
5806a43 to
fa307f0
Compare
Merging this PR will improve performance by 10.94%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
Docs improvement to have better clarity and less verbosity